<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 12 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.E-MailFormatvorlage17
{mso-style-type:personal-compose;
font-family:Consolas;
color:windowtext;}
span.st
{mso-style-name:st;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=DE link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:10.5pt;font-family:Consolas'>Hello tac_plus developers,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.5pt;font-family:Consolas'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'>First of all I would like to thank you for the great tacacs+ implementation.<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'>While testing around with the acl of Version F4.0.4.20 I discovered<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'>a bug in the procedure cfg_acl_check (implemented in the file config.c).<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'>The line<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'> if (regexec((regex_t *)next->value1, ip, 0, NULL, 0)) {<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'>should be<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'> if (regexec((regex_t *)next->value1, ip, 0, NULL, 0) == 0) {<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'>From different sources:<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'>“</span><em><span lang=EN-GB style='font-family:"Calibri","sans-serif"'>If regexec</span></em><span class=st><span lang=EN-GB>() finds a match it returns zero; otherwise, it returns nonzero”<o:p></o:p></span></span></p><p class=MsoNormal><span class=st><span lang=EN-GB>“regexec() returns zero for a successful match or REG_NOMATCH for failure”</span></span><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'>Therefore all the acl work something like inverse which could lead<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'>to serious security holes.<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'>Kind regards<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-GB style='font-size:10.5pt;font-family:Consolas'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:Consolas'>Valentin Schmid<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:Consolas'>Systemengineering<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:Consolas'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:Consolas'>aurax connecta ag<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.5pt;font-family:Consolas'>Betreiber von KnS und ilnet<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.5pt;font-family:Consolas'>Bahnhofstrasse 2<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.5pt;font-family:Consolas'>7130 Ilanz<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.5pt;font-family:Consolas'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:10.5pt;font-family:Consolas'>Telefon: +41 81 926 27 28<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.5pt;font-family:Consolas'>Telefax: +41 81 926 27 29<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:10.5pt;font-family:Consolas'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:Consolas'><a href="http://www.kns.ch"><span lang=DE style='color:blue'>http://www.kns.ch</span></a></span><span style='font-size:10.5pt;font-family:Consolas'><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:10.5pt;font-family:Consolas'><a href="http://www.ilnet.ch"><span style='color:blue'>http://www.ilnet.ch</span></a><o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p></div></body></html>