[rancid] Problem backing up HP switches on RHEL 6.2 (x86_64) -- patch included

[heasley]

Wed, Feb 08, 2012 at 12:52:12PM +0100, David Byers:
> On 2010-06-25 a change was checked in to GNU libc that changes how 
> memcpy works on certain architectures. Previously it copied overlapping 
> memory regions correctly; now it doesn't.
> 
> The net result for rancid is that backups of HP switches don't work on 
> e.g. RedHat Enterprise Linux with glibc-2.12-1.47 (x86_64). The output 
> gets garbled, and rancid fails to complete the backup process in many 
> cases. The cause appears to be memcpy calls in hpuifilter.
> 
> The patch below appears to solve the problem (at least our backups look 
> OK again); I've simply replaced all memcpy calls with calls to memmove; 
> probably some of them don't need to be replaced, but I don't see any 
> harm in doing so -- memmove may be a little slower, but I doubt that 
> this is a bottleneck in rancid.

Oh, you are a gentleman and a scholar.  Thanks!  It must now be using block
copy ops.